feat: wrapApprove intent wiring (sendMany type + prebuild + shieldParams passthrough) - #9556

CHALO-1340

@claude

Claude finished @0xPrabh's task —— View job

Code Review Complete ✅

I've completed a thorough review of the wrapApprove intent wiring implementation. Here's my analysis:

Architecture & Implementation ✅

The implementation correctly wires wrapApprove and wrap intent types through the TSS system:

1. Type Safety: Added WrapIntentParams interface in baseTypes.ts:302-306 with proper validation
2. Intent Population: Enhanced mpcUtils.ts:339-357 to flatten wrapParams onto WP intents with proper validation
3. No-Recipient Support: Correctly added wrap to NO_RECIPIENT_TX_TYPES (line 36) alongside existing wrapApprove
4. Parameter Passthrough: Added wrapParams to BuildParams.ts:165 and iWallet.ts:300-306

Validation & Security ✅

• Input validation: Proper checks for required wrapParams, non-empty tokenName, and positive integer amount (lines 341-349)
• Type guards: EVM + TSS checks ensure correct coin family usage
• No recipients validation: Correctly bypasses recipient requirements for wrap operations

Test Coverage ✅

Comprehensive test suite covering:

• Intent population with proper field flattening (mpcUtils.wrapApprove.ts)
• Parameter validation (required fields, positive amounts)
• Wallet prebuild integration tests (wallet.ts:3629-3680)
• No-recipient validation (recipientUtils.ts)

Code Quality ✅

• Consistency: Follows existing patterns for DeFi intents
• Documentation: Clear JSDoc comments explaining ERC-7984 usage
• Error Messages: Descriptive validation error messages
• Naming: Consistent with existing defiParams pattern

Minor Observations

1. Regex Pattern: The amount validation regex /^[1-9]\d*$/ correctly excludes zero and negatives
2. Field Mapping: Proper flattening from nested wrapParams to top-level intent fields
3. TSS Integration: Correctly integrated with existing TSS prebuild flow

The implementation is well-architected, thoroughly tested, and follows BitGoJS conventions. The approach of flattening wrap parameters onto the intent (similar to defi operations) is consistent and appropriate.

CI Status: 2 workflows in progress
Branch: CHALO-1340

⚠️ Unit tests are failing on Node 26.x (Current release line, non-blocking). This is not an LTS version yet, so it does not block merge, but it signals an incompatibility to fix before Node 26.x becomes LTS.

View run